Don't consider PHP core classes as dependencies#552
Merged
Conversation
fain182
force-pushed
the
claude/fix-issue-338-iv0tO
branch
2 times, most recently
from
a063196 to
9b0eb11
Compare
PHP core classes (DateTime, Exception, PDO, etc.) are now automatically filtered during dependency extraction in ClassDescriptionBuilder. This eliminates the need for users to manually exclude them in rules. Changes: - Add isPhpCoreClass() method to ClassDescriptionBuilder that uses ReflectionClass::isInternal() to accurately detect PHP built-in classes from both core and extensions (including namespaced ones like MongoDB\Driver\Manager, Swoole\Server) - Remove obsolete excludeCoreNamespace parameter from NotHaveDependencyOutsideNamespace rule (no longer needed) - Add comprehensive tests for PHP core class filtering, including verification that internal namespaced classes are also filtered - Update README to document automatic exclusion behavior The filtering uses Reflection on all dependencies, not just root namespace classes, ensuring extensions with namespaced classes (MongoDB, Swoole, etc.) are also correctly excluded.
fain182
force-pushed
the
claude/fix-issue-338-iv0tO
branch
from
9b0eb11 to
7d5f129
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=========================================
Coverage 97.80% 97.80%
+ Complexity 628 627 -1
=========================================
Files 81 81
Lines 1822 1824 +2
=========================================
+ Hits 1782 1784 +2
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolved conflict in README.md:
- Kept our simplified API (removed excludeCoreNamespace parameter)
- Adopted grammar improvements from main ('to protect' instead of 'protect')
- Integrated RuleBuilder cloning fix from main (issue #303)
The checks for root namespace in DependsOnlyOnTheseNamespaces and NotDependsOnTheseNamespaces are no longer needed since PHP core classes are now filtered upstream in ClassDescriptionBuilder. These checks were originally added to skip PHP core classes, but now: - PHP internal classes are filtered at the dependency collection level - User-defined classes in root namespace are properly handled This makes the rules simpler and more consistent.
Follow clean code principles: remove comments that explain 'what' or 'how' (obvious from the code) and keep only comments that explain 'why' when needed. Removed comments like: - 'Filter out PHP core classes' (method name is clear) - 'skip classes in the same namespace' (obvious from condition) - 'PHP core - filtered' in tests (evident from assertion) The code is self-documenting through clear method and variable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP core classes (DateTime, Exception, PDO, etc.) are now automatically filtered during dependency extraction in ClassDescriptionBuilder. This eliminates the need for users to manually exclude them in rules.
Changes:
The filtering is more precise than the previous approach - it only excludes actual PHP internal classes, not all classes without a namespace, preventing false negatives for legacy user-defined classes.
fixes #338